Change provision_devices.py to disable verity for remove webview on M

build/android/provision_devices.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provisions Android devices with settings required for bots.
 
 Usage:
   ./provision_devices.py [-d <device serial number>]
@@ skipping 277 matching lines @@
   if options.disable_network:
     device_settings.ConfigureContentSettings(
         device, device_settings.NETWORK_DISABLED_SETTINGS)
 
   if options.disable_system_chrome:
     # The system chrome version on the device interferes with some tests.
     device.RunShellCommand(['pm', 'disable', 'com.android.chrome'],
                            check_return=True)
 
   if options.remove_system_webview:
-    if device.HasRoot():
-      # This is required, e.g., to replace the system webview on a device.
-      device.adb.Remount()
-      device.RunShellCommand(['stop'], check_return=True)
-      device.RunShellCommand(['rm', '-rf'] + _SYSTEM_WEBVIEW_PATHS,
-                             check_return=True)
-      device.RunShellCommand(['start'], check_return=True)
+    original_webview_exist = False

[jbudorick, 2016/05/10 22:28:44]

These four lines can just be:

  if any(device.PathExists(p) for p in _SYSTEM_WEBVIEW_PATHS):
    ...

[Yoland Yan(Google), 2016/05/10 22:36:48]

Nicee, done!

+    for p in _SYSTEM_WEBVIEW_PATHS:
+      original_webview_exist = original_webview_exist or device.PathExists(p)
+    if original_webview_exist:
+      logging.info('Original WebView exists and needs to be removed')
+      if device.HasRoot():
+        # Disabled Marshmallow's Verity security feature
+        if device.build_version_sdk >= version_codes.MARSHMALLOW:
+          device.adb.DisableVerity()
+          device.Reboot()
+          device.WaitUntilFullyBooted()
+          device.EnableRoot()
+        # This is required, e.g., to replace the system webview on a device.

[jbudorick, 2016/05/10 22:28:44]

nit: line break before this line

[Yoland Yan(Google), 2016/05/10 22:36:48]

Done.

+        device.adb.Remount()
+        device.RunShellCommand(['stop'], check_return=True)
+        device.RunShellCommand(['rm', '-rf'] + _SYSTEM_WEBVIEW_PATHS,
+                               check_return=True)
+        device.RunShellCommand(['start'], check_return=True)
+      else:
+        logging.warning('Cannot remove system webview from a non-rooted device')
     else:
-      logging.warning('Cannot remove system webview from a non-rooted device')
+      logging.info('Original WebView already removed')

[jbudorick, 2016/05/10 22:28:44]

nit: "system webview" instead of "original webview"

[Yoland Yan(Google), 2016/05/10 22:36:48]

Done.

 
   # Some device types can momentarily disappear after setting properties.
   device.adb.WaitForDevice()
 
 
 def _ConfigureLocalProperties(device, java_debug=True):
   """Set standard readonly testing device properties prior to reboot."""
   local_props = [
       'persist.sys.usb.config=adb',
       'ro.monkey=1',
@@ skipping 219 matching lines @@
       },
     }
 
   devil_chromium.Initialize(custom_deps=devil_custom_deps)
 
   return ProvisionDevices(args)
 
 
 if __name__ == '__main__':
   sys.exit(main())