appengine/findit/common/auth_util.py - Issue 1960353002: [Findit] Use gerric scope instead of email scope to authorize findit to internal buildspec/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/common/auth_util.py

Issue 1960353002: [Findit] Use gerric scope instead of email scope to authorize findit to internal buildspec/ (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/common/auth_util.py

diff --git a/appengine/findit/common/auth_util.py b/appengine/findit/common/auth_util.py

index e9fe427e9ec6d977c355998b2fb4e9443cf307e5..43d60b74808611843d73baf9f69fe3f27c8c05d0 100644

--- a/appengine/findit/common/auth_util.py

+++ b/appengine/findit/common/auth_util.py

@@ -8,7 +8,7 @@ from google.appengine.api.app_identity import app_identity

_EMAIL_SCOPE = 'https://www.googleapis.com/auth/userinfo.email'

-def GetAuthToken(): # pragma: no cover

+def GetAuthToken(scope=_EMAIL_SCOPE): # pragma: no cover

"""Gets auth token for requests to swarming server and isolated server."""

stgao 2016/05/09 21:44:45 This needs updating now.

Sharu Jiang 2016/05/09 22:01:48 Done.

- auth_token, _ = app_identity.get_access_token(_EMAIL_SCOPE)

+ auth_token, _ = app_identity.get_access_token(scope)

return auth_token

« no previous file with comments | « no previous file | appengine/findit/common/http_client_appengine.py » ('j') | no next file with comments »