[Findit] Use gerric scope instead of email scope to authorize findit to internal buildspec/

[Findit] Use gerric scope instead of email scope to authorize findit to internal buildspec/

For internal buildspec/ (https://chrome-internal.googlesource.com/chrome/tools/buildspec.git/), the scope for authentication should be https://www.googleapis.com/auth/gerritcodereview instead of https://www.googleapis.com/auth/userinfo.email.

BUG=605356
Committed: https://chromium.googlesource.com/infra/infra/+/fb53695b44cc578a02b2d00c9e11b1ed316dde39

[Sharu Jiang, 2016-05-09 20:57:06]

Description was changed from

==========
Change access scope.

BUG=
==========

to

==========
For internal buildspec/, the scope for authentication should be
https://www.googleapis.com/auth/gerritcodereview instead of
https://www.googleapis.com/auth/userinfo.email.

BUG=605356
==========

[Sharu Jiang, 2016-05-09 20:57:07]

katesonia@chromium.org changed reviewers:
+ stgao@chromium.org

[Sharu Jiang, 2016-05-09 20:57:30]

Description was changed from

==========
For internal buildspec/, the scope for authentication should be
https://www.googleapis.com/auth/gerritcodereview instead of
https://www.googleapis.com/auth/userinfo.email.

BUG=605356
==========

to

==========
[Findit] Use gerric scope instead of email scope to authorize findit to internal
buildspec/

For internal buildspec/, the scope for authentication should be
https://www.googleapis.com/auth/gerritcodereview instead of
https://www.googleapis.com/auth/userinfo.email.

BUG=605356
==========

[Sharu Jiang, 2016-05-09 20:58:17]

This is to resolve the 403 issue accessing the internal buildspec/ repo -
https://chrome-internal.googlesource.com/chrome/tools/buildspec.git/.

[Sharu Jiang, 2016-05-09 20:58:29]

PTAL :)

[Sharu Jiang, 2016-05-09 20:58:45]

Description was changed from

==========
[Findit] Use gerric scope instead of email scope to authorize findit to internal
buildspec/

For internal buildspec/, the scope for authentication should be
https://www.googleapis.com/auth/gerritcodereview instead of
https://www.googleapis.com/auth/userinfo.email.

BUG=605356
==========

to

==========
[Findit] Use gerric scope instead of email scope to authorize findit to internal
buildspec/

For internal buildspec/
(https://chrome-internal.googlesource.com/chrome/tools/buildspec.git/), the
scope for authentication should be
https://www.googleapis.com/auth/gerritcodereview instead of
https://www.googleapis.com/auth/userinfo.email.

BUG=605356
==========

[stgao, 2016-05-09 21:44:45]

lgtm

https://codereview.chromium.org/1960353002/diff/1/appengine/findit/common/aut...
File appengine/findit/common/auth_util.py (right):

https://codereview.chromium.org/1960353002/diff/1/appengine/findit/common/aut...
appengine/findit/common/auth_util.py:12: """Gets auth token for requests to
swarming server and isolated server."""
This needs updating now.

[Sharu Jiang, 2016-05-09 22:01:48]

https://codereview.chromium.org/1960353002/diff/1/appengine/findit/common/aut...
File appengine/findit/common/auth_util.py (right):

https://codereview.chromium.org/1960353002/diff/1/appengine/findit/common/aut...
appengine/findit/common/auth_util.py:12: """Gets auth token for requests to
swarming server and isolated server."""
On 2016/05/09 21:44:45, stgao wrote:
> This needs updating now.

Done.

[Sharu Jiang, 2016-05-09 22:02:34]

The CQ bit was checked by katesonia@chromium.org

[Sharu Jiang, 2016-05-09 22:02:34]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/1960353002/#ps20001
(title: "Update doc string.")

[commit-bot: I haz the power, 2016-05-09 22:02:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960353002/20001

[commit-bot: I haz the power, 2016-05-09 22:07:03]

Description was changed from

==========
[Findit] Use gerric scope instead of email scope to authorize findit to internal
buildspec/

For internal buildspec/
(https://chrome-internal.googlesource.com/chrome/tools/buildspec.git/), the
scope for authentication should be
https://www.googleapis.com/auth/gerritcodereview instead of
https://www.googleapis.com/auth/userinfo.email.

BUG=605356
==========

to

==========
[Findit] Use gerric scope instead of email scope to authorize findit to internal
buildspec/

For internal buildspec/
(https://chrome-internal.googlesource.com/chrome/tools/buildspec.git/), the
scope for authentication should be
https://www.googleapis.com/auth/gerritcodereview instead of
https://www.googleapis.com/auth/userinfo.email.

BUG=605356

Committed:
https://chromium.googlesource.com/infra/infra/+/fb53695b44cc578a02b2d00c9e11b...
==========

[commit-bot: I haz the power, 2016-05-09 22:07:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/fb53695b44cc578a02b2d00c9e11b...