Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1818)

Side by Side Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 1960323002: MD Settings: Use shared cr_elements iconset when possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@CrIconsCrOS
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-internet-detail' is the settings subpage containing details 7 * 'settings-internet-detail' is the settings subpage containing details
8 * for a network. 8 * for a network.
9 */ 9 */
10 (function() { 10 (function() {
(...skipping 529 matching lines...) Expand 10 before | Expand all | Expand 10 after
540 // properties.Type == CrOnc.Type.ETHERNET. 540 // properties.Type == CrOnc.Type.ETHERNET.
541 return properties.Source != CrOnc.Source.NONE; 541 return properties.Source != CrOnc.Source.NONE;
542 }, 542 },
543 543
544 /** 544 /**
545 * @param {boolean} preferNetwork 545 * @param {boolean} preferNetwork
546 * @return {string} The icon to use for the preferred button. 546 * @return {string} The icon to use for the preferred button.
547 * @private 547 * @private
548 */ 548 */
549 getPreferredIcon_: function(preferNetwork) { 549 getPreferredIcon_: function(preferNetwork) {
550 return preferNetwork ? 'star' : 'star-border'; 550 return preferNetwork ? 'cr:star' : 'cr:star-border';
551 }, 551 },
552 552
553 /** 553 /**
554 * @param {!CrOnc.NetworkProperties} properties 554 * @param {!CrOnc.NetworkProperties} properties
555 * @return {!Array<string>} The fields to display in the info section. 555 * @return {!Array<string>} The fields to display in the info section.
556 * @private 556 * @private
557 */ 557 */
558 getInfoFields_: function(properties) { 558 getInfoFields_: function(properties) {
559 /** @type {!Array<string>} */ var fields = []; 559 /** @type {!Array<string>} */ var fields = [];
560 if (!properties) 560 if (!properties)
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 */ 701 */
702 allPropertiesMatch_: function(curValue, newValue) { 702 allPropertiesMatch_: function(curValue, newValue) {
703 for (let key in newValue) { 703 for (let key in newValue) {
704 if (newValue[key] != curValue[key]) 704 if (newValue[key] != curValue[key])
705 return false; 705 return false;
706 } 706 }
707 return true; 707 return true;
708 } 708 }
709 }); 709 });
710 })(); 710 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698