Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: components/cronet/android/cronet_bidirectional_stream_adapter.h

Issue 1960243002: Fix leak in CronetBidirectionalStreamAdapter::OnDataSent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/cronet_bidirectional_stream_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/cronet_bidirectional_stream_adapter.h
diff --git a/components/cronet/android/cronet_bidirectional_stream_adapter.h b/components/cronet/android/cronet_bidirectional_stream_adapter.h
index 8106c703797c902b3b14334ecfd9c0a83b013a07..4ed2dea985f4ec8e7787da535d563387fea15b25 100644
--- a/components/cronet/android/cronet_bidirectional_stream_adapter.h
+++ b/components/cronet/android/cronet_bidirectional_stream_adapter.h
@@ -94,7 +94,8 @@ class CronetBidirectionalStreamAdapter
jboolean jsend_on_canceled);
private:
- typedef std::vector<scoped_refptr<IOBufferWithByteBuffer>> IOByteBufferList;
+ typedef std::vector<scoped_refptr<IOBufferWithByteBuffer>>
+ IOBufferWithByteBufferList;
// net::BidirectionalStream::Delegate implementations:
void OnStreamReady() override;
void OnHeadersReceived(const net::SpdyHeaderBlock& response_headers) override;
@@ -108,7 +109,7 @@ class CronetBidirectionalStreamAdapter
void ReadDataOnNetworkThread(
scoped_refptr<IOBufferWithByteBuffer> read_buffer,
int buffer_size);
- void WritevDataOnNetworkThread(const IOByteBufferList& buffers,
+ void WritevDataOnNetworkThread(const IOBufferWithByteBufferList& buffers,
bool end_of_stream);
void DestroyOnNetworkThread(bool send_on_canceled);
// Gets headers as a Java array.
@@ -126,7 +127,7 @@ class CronetBidirectionalStreamAdapter
bool write_end_of_stream_;
scoped_refptr<IOBufferWithByteBuffer> read_buffer_;
- IOByteBufferList write_buffer_list_;
+ IOBufferWithByteBufferList write_buffer_list_;
std::unique_ptr<net::BidirectionalStream> bidi_stream_;
// Whether BidirectionalStream::Delegate::OnFailed callback is invoked.
« no previous file with comments | « no previous file | components/cronet/android/cronet_bidirectional_stream_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698