Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 196023005: [WebSocket] Create an isolated copy of the KURL parameter in Bridge::Connect() (Closed)

Created:
6 years, 9 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 9 months ago
Reviewers:
kinuko
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[WebSocket] Create an isolated copy of the KURL parameter in Bridge::Connect() WorkerThreadableWebSocketChannel::Bridge::connect() creates a closure of Peer::connect call from url. Since this closure will be used by the main thread while this method is called from the worker thread, we need to create an isolated copy of it. Recent refactoring changed this method to use CallClosureTask::create + bind from createCallbackTask. Since createCallbackTask wraps arguments with CrossThreadCopier, not calling copy() on url was not a problem in the old code. On the other hand, in Bridge::initializ(), isolateCopy() call on sourceURL is redundant since createCallbackTask is used there. This change removes it. BUG=351292 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168992

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 9 months ago (2014-03-12 05:09:51 UTC) #1
kinuko
lgtm, thx
6 years, 9 months ago (2014-03-12 05:33:03 UTC) #2
kinuko
https://codereview.chromium.org/196023005/diff/1/Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp File Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp (right): https://codereview.chromium.org/196023005/diff/1/Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp#newcode468 Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp:468: m_loaderProxy.postTaskToLoader(createCallbackTask(&Peer::initialize, reference.release(), AllowCrossThreadAccess(&m_loaderProxy), m_workerClientWrapper, sourceURL, lineNumber, syncHelper.release())); (I always ...
6 years, 9 months ago (2014-03-12 05:33:15 UTC) #3
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 9 months ago (2014-03-12 05:45:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/196023005/1
6 years, 9 months ago (2014-03-12 05:45:06 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 08:01:30 UTC) #6
Message was sent while issue was closed.
Change committed as 168992

Powered by Google App Engine
This is Rietveld 408576698