MD Downloads: reset list tracker when renderer crashes

chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h"
 
 #include <algorithm>
 #include <functional>
 
 #include "base/bind.h"
@@ skipping 113 matching lines @@
                  weak_ptr_factory_.GetWeakPtr()));
   web_ui()->RegisterMessageCallback("cancel",
       base::Bind(&MdDownloadsDOMHandler::HandleCancel,
                  weak_ptr_factory_.GetWeakPtr()));
   web_ui()->RegisterMessageCallback("clearAll",
       base::Bind(&MdDownloadsDOMHandler::HandleClearAll,
                  weak_ptr_factory_.GetWeakPtr()));
   web_ui()->RegisterMessageCallback("openDownloadsFolder",
       base::Bind(&MdDownloadsDOMHandler::HandleOpenDownloadsFolder,
                  weak_ptr_factory_.GetWeakPtr()));
+
+  Observe(GetWebUIWebContents());
 }
 
 void MdDownloadsDOMHandler::OnJavascriptDisallowed() {
   list_tracker_.Stop();
   list_tracker_.Reset();
   CheckForRemovedFiles();
 }
 
+void MdDownloadsDOMHandler::RenderProcessGone(base::TerminationStatus status) {
+  if (status != base::TERMINATION_STATUS_NORMAL_TERMINATION &&

[tommycli, 2016/05/09 17:54:35]

Does using WebContents::IsCrashed() work here instead?

Also... maybe we should just always DisallowJavascript. I can't think of any
case where the RenderProcess is Gone (even for non-crash reasons) that we would
not want to disallow JS.

[Dan Beam, 2016/05/09 18:29:32]

Done.

+      status != base::TERMINATION_STATUS_STILL_RUNNING) {
+    // TODO(dbeam): WebUI + WebUIMessageHandler should do this automatically.
+    DisallowJavascript();
+  }
+}
+
 void MdDownloadsDOMHandler::HandleGetDownloads(const base::ListValue* args) {
   AllowJavascript();
 
   CountDownloadsDOMEvents(DOWNLOADS_DOM_EVENT_GET_DOWNLOADS);
 
   bool terms_changed = list_tracker_.SetSearchTerms(*args);
   if (terms_changed)
     list_tracker_.Reset();
 
   list_tracker_.StartAndSendChunk();
@@ skipping 260 matching lines @@
 content::WebContents* MdDownloadsDOMHandler::GetWebUIWebContents() {
   return web_ui()->GetWebContents();
 }
 
 void MdDownloadsDOMHandler::CheckForRemovedFiles() {
   if (GetMainNotifierManager())
     GetMainNotifierManager()->CheckForHistoryFilesRemoval();
   if (GetOriginalNotifierManager())
     GetOriginalNotifierManager()->CheckForHistoryFilesRemoval();
 }