Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1960213002: Skip adding line based range data for ranges that don't map to a line. (Closed)

Created:
4 years, 7 months ago by Cutch
Modified:
4 years, 7 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip adding line based range data for ranges that don't map to a line. BUG= R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/5331af35bc2f77afdba8acdfe25db2a1bba57787

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M runtime/observatory/lib/src/elements/script_inset.dart View 1 chunk +8 lines, -6 lines 2 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 7 months ago (2016-05-09 16:13:37 UTC) #3
turnidge
lgtm w/ 1 comment. https://codereview.chromium.org/1960213002/diff/1/runtime/observatory/lib/src/elements/script_inset.dart File runtime/observatory/lib/src/elements/script_inset.dart (right): https://codereview.chromium.org/1960213002/diff/1/runtime/observatory/lib/src/elements/script_inset.dart#newcode600 runtime/observatory/lib/src/elements/script_inset.dart:600: if ((startLine != null) && ...
4 years, 7 months ago (2016-05-09 19:20:12 UTC) #4
Cutch
https://codereview.chromium.org/1960213002/diff/1/runtime/observatory/lib/src/elements/script_inset.dart File runtime/observatory/lib/src/elements/script_inset.dart (right): https://codereview.chromium.org/1960213002/diff/1/runtime/observatory/lib/src/elements/script_inset.dart#newcode600 runtime/observatory/lib/src/elements/script_inset.dart:600: if ((startLine != null) && (endLine != null)) { ...
4 years, 7 months ago (2016-05-09 20:40:04 UTC) #5
Cutch
4 years, 7 months ago (2016-05-09 20:40:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5331af35bc2f77afdba8acdfe25db2a1bba57787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698