Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1960203002: Revert of [WebViewShellLayoutTest] Fix AOSP bots failure testWebViewExcludedInterfaces. (Closed)

Created:
4 years, 7 months ago by gsennton
Modified:
4 years, 7 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [WebViewShellLayoutTest] Fix AOSP bots failure testWebViewExcludedInterfaces. (patchset #2 id:20001 of https://codereview.chromium.org/1951253003/ ) Reason for revert: Fix WebViewLayoutTest failures due to https://codereview.chromium.org/1380503002 being reverted. Reverting the current CL and https://codereview.chromium.org/1950943002/ (that revert is in https://codereview.chromium.org/1960923003/) BUG=609448 Original issue's description: > [WebViewShellLayoutTest] Fix AOSP bots failure testWebViewExcludedInterfaces. > > Fix exclude list due to https://codereview.chromium.org/1380503002 > > Should fix WebView L and WebView M AOSP bots. > > BUG=608979, 609448 > > Committed: https://crrev.com/f1ef7ba0f99e5538922ae9c936ffba2138c8bdf9 > Cr-Commit-Position: refs/heads/master@{#391803} TBR=mlamouri@chromium.org,torne@chromium.org,timvolodine@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608979, 609448 Committed: https://crrev.com/90cdf6675f4f91aa68fb12709c46eac1a658dc3d Cr-Commit-Position: refs/heads/master@{#392340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
gsennton
Created Revert of [WebViewShellLayoutTest] Fix AOSP bots failure testWebViewExcludedInterfaces.
4 years, 7 months ago (2016-05-09 16:04:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960203002/1
4 years, 7 months ago (2016-05-09 16:05:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 17:02:44 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 17:04:19 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90cdf6675f4f91aa68fb12709c46eac1a658dc3d
Cr-Commit-Position: refs/heads/master@{#392340}

Powered by Google App Engine
This is Rietveld 408576698