Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1960193002: Revert "Adds `DartOptions` to generic method syntax tests." (Closed)

Created:
4 years, 7 months ago by eernst
Modified:
4 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Adds `DartOptions` to generic method syntax tests." This reverts commit ae31db041d192232c2e65e10577c17689be6e747, which seemed to cause failures on dart2js-d8-minified. BUG= Committed: https://github.com/dart-lang/sdk/commit/a9d90f4a09ee30140bb99e781cb566d8536c1bdd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M tests/language/generic_functions_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/generic_local_functions_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/generic_methods_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/generic_sends_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language.status View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
eernst
TBR: Reverting (failures on dart2js-d8-minified).
4 years, 7 months ago (2016-05-09 16:06:13 UTC) #3
eernst
4 years, 7 months ago (2016-05-09 16:06:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a9d90f4a09ee30140bb99e781cb566d8536c1bdd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698