Remove some dead code.

Remove some dead code.

- No caller checks the CPDF_VariableText::SetProvider() return value.
- IFX_Edit::SetVTProvider() is unused.
- CFX_ListItem::SetCaret() is useless.
- CFX_List::SetItemCaret() is also useless.
- CPVT_GenerateAP::GenerateEditAP() has a param that's always NULL.

Committed: https://pdfium.googlesource.com/pdfium/+/2c3a16a7698ba15476173e849f82c97ea3da9939

[Lei Zhang, 2016-05-10 18:25:43]

thestig@chromium.org changed reviewers:
+ weili@chromium.org

[Wei Li, 2016-05-10 19:47:33]

lgtm

[Lei Zhang, 2016-05-10 20:23:49]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-05-10 20:23:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960183003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960183003/1

[commit-bot: I haz the power, 2016-05-10 20:24:21]

Description was changed from

==========
Remove some dead code.

- No caller checks the CPDF_VariableText::SetProvider() return value.
- IFX_Edit::SetVTProvider() is unused.
- CFX_ListItem::SetCaret() is useless.
- CFX_List::SetItemCaret() is also useless.
- CPVT_GenerateAP::GenerateEditAP() has a param that's always NULL.
==========

to

==========
Remove some dead code.

- No caller checks the CPDF_VariableText::SetProvider() return value.
- IFX_Edit::SetVTProvider() is unused.
- CFX_ListItem::SetCaret() is useless.
- CFX_List::SetItemCaret() is also useless.
- CPVT_GenerateAP::GenerateEditAP() has a param that's always NULL.

Committed:
https://pdfium.googlesource.com/pdfium/+/2c3a16a7698ba15476173e849f82c97ea3da...
==========

[commit-bot: I haz the power, 2016-05-10 20:24:21]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/2c3a16a7698ba15476173e849f82c97ea3da...