Fix loading bubble not disappearing with corrupt theme image....

Fix loading bubble not disappearing with corrupt theme image.

BUG= http://crbug.com/21044
TEST= try installing a theme with a corrupt image.  note that loading bubble disappears.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25401

[Miranda Callahan, 2009-09-03 23:04:57]

Added a notification for the case that the theme install fails in the unpacker.

[Erik does not do reviews, 2009-09-03 23:11:26]

LGTM


On Thu, Sep 3, 2009 at 4:04 PM, <mirandac@chromium.org> wrote:
> Reviewers: Erik Kay,
>
> Message:
> Added a notification for the case that the theme install fails in the
> unpacker.
>
> Description:
> Fix loading bubble not disappearing with corrupt theme image.
>
> BUG=3D http://crbug.com/21044
> TEST=3D try installing a theme with a corrupt image. =A0note that loading
> bubble disappears.
>
>
> Please review this at http://codereview.chromium.org/196016
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/browser/extensions/crx_installer.cc
>
>
> Index: chrome/browser/extensions/crx_installer.cc
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/extensions/crx_installer.cc =A0(revision 25059)
> +++ chrome/browser/extensions/crx_installer.cc =A0(working copy)
> @@ -12,6 +12,8 @@
> =A0#include "chrome/browser/browser_process.h"
> =A0#include "chrome/browser/extensions/extension_file_util.h"
> =A0#include "chrome/common/extensions/extension_error_reporter.h"
> +#include "chrome/common/notification_service.h"
> +#include "chrome/common/notification_type.h"
> =A0#include "grit/chromium_strings.h"
> =A0#include "third_party/skia/include/core/SkBitmap.h"
> =A0#include "webkit/glue/image_decoder.h"
> @@ -252,6 +254,11 @@
> =A0void CrxInstaller::ReportFailureFromUIThread(const std::string& error)=
 {
> =A0 DCHECK(MessageLoop::current() =3D=3D ui_loop_);
>
> + =A0NotificationService* service =3D NotificationService::current();
> + =A0service->Notify(NotificationType::NO_THEME_DETECTED,
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0Source<CrxInstaller>(this),
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0NotificationService::NoDetails());
> +
> =A0 // This isn't really necessary, it is only used because unit tests ex=
pect
> to
> =A0 // see errors get reported via this interface.
> =A0 //
>
>
>