Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1960153002: DEPS: update icu + sfntly (Closed)

Created:
4 years, 7 months ago by hal.canary
Modified:
4 years, 7 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 2016-05-09 (Monday) 10:37:55 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M gyp/sfntly.gyp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
hal.canary
PTAL
4 years, 7 months ago (2016-05-09 14:18:46 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960153002/1
4 years, 7 months ago (2016-05-09 14:21:58 UTC) #6
scroggo
lgtm
4 years, 7 months ago (2016-05-09 14:23:19 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/8454)
4 years, 7 months ago (2016-05-09 14:25:27 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960153002/20001
4 years, 7 months ago (2016-05-09 14:38:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960153002/20001
4 years, 7 months ago (2016-05-09 14:49:44 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 15:00:30 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7a223f5825db96d6499523872ea32d5dba8d2667

Powered by Google App Engine
This is Rietveld 408576698