Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1960143002: [wasm] Add some tests for control flow corner cases. (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
Reviewers:
ahaas, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Committed: https://crrev.com/86d4a45586227f66f0740c84c801043bd5f75de8 Cr-Commit-Position: refs/heads/master@{#36112}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add even more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
M test/cctest/wasm/test-run-wasm.cc View 1 3 chunks +78 lines, -0 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
titzer
4 years, 7 months ago (2016-05-09 13:55:35 UTC) #1
ahaas
lgtm https://codereview.chromium.org/1960143002/diff/1/test/cctest/wasm/test-run-wasm.cc File test/cctest/wasm/test-run-wasm.cc (right): https://codereview.chromium.org/1960143002/diff/1/test/cctest/wasm/test-run-wasm.cc#newcode693 test/cctest/wasm/test-run-wasm.cc:693: BUILD(r, WASM_GET_LOCAL(0), kExprIf, kExprEnd, WASM_GET_LOCAL(0)); Could you use ...
4 years, 7 months ago (2016-05-09 14:02:59 UTC) #2
titzer
https://codereview.chromium.org/1960143002/diff/1/test/cctest/wasm/test-run-wasm.cc File test/cctest/wasm/test-run-wasm.cc (right): https://codereview.chromium.org/1960143002/diff/1/test/cctest/wasm/test-run-wasm.cc#newcode693 test/cctest/wasm/test-run-wasm.cc:693: BUILD(r, WASM_GET_LOCAL(0), kExprIf, kExprEnd, WASM_GET_LOCAL(0)); On 2016/05/09 14:02:59, ahaas ...
4 years, 7 months ago (2016-05-09 14:18:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960143002/20001
4 years, 7 months ago (2016-05-09 14:19:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 14:45:44 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 14:46:46 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86d4a45586227f66f0740c84c801043bd5f75de8
Cr-Commit-Position: refs/heads/master@{#36112}

Powered by Google App Engine
This is Rietveld 408576698