This changelist fixes some issues with the NPAPI WMP plugin work in Chrome. ...

This changelist fixes some issues with the NPAPI WMP plugin work in Chrome.  The first is that we need to disable windowless mode since it doesn't work in the NPAPI plugin (Safari does this as well, and sites don't use windowless for Firefox).  The second is to make UpdateGeometry message synchronous for WMP.  The problem I saw was that while handling that message, the plugin might disaptch a NPObject Invoke method to play a video, which WMP doesn't expect and it leads to the video never playing.

While touching these files, I made some small cleanup by reverting the change that made WebPluginProxy not have a WebPluginDelegateImpl pointer, which added a bunch of unnecessary methods to WebPluginDelegate.

BUG=20259
TEST=use --no-activex and try playing the videos on http://www.nana10.co.il/Section/?SectionID=10847&sid=235

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25433

[jam, 2009-09-04 05:47:30]

On Thu, Sep 3, 2009 at 10:37 PM, <ananta@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.org/196012/diff/1/20
> File chrome/renderer/webplugin_delegate_proxy.cc (right):
>
> http://codereview.chromium.org/196012/diff/1/20#newcode434
> Line 434: if (transport_store_.get()) {
> The original code had the following check as well.
> if (transport_store_.get() && background_store.get() {
>  blah blah
> }


> Is this not needed anymore?
>

I simplified the logic and moved it up a few lines.


>
> http://codereview.chromium.org/196012/diff/1/20#newcode448
> Line 448: msg = new PluginMsg_UpdateGeometrySync(instance_id_, param);
> Sad that the UpdateGeometry message needs to be sync :(


I think it's interesting that we never hit this with Flash or other plugins
before, but either way it's only sync for WMP.


>
>
> http://codereview.chromium.org/196012
>