Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1960113002: V8: Fix OS X build of ARM 64 test. (Closed)

Created:
4 years, 7 months ago by bbudge
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

V8: Fix OS X build of ARM 64 test. Fixes 4 compile errors on Mac due to specifiers not matching type casts. LOG=N BUG= Committed: https://crrev.com/b466adfe47368737c0ed2e48a96c85e46a7d5f4d Cr-Commit-Position: refs/heads/master@{#36115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M test/cctest/test-run-wasm-relocation-arm64.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bbudge
4 years, 7 months ago (2016-05-09 12:55:16 UTC) #2
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-09 17:27:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960113002/1
4 years, 7 months ago (2016-05-09 17:28:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960113002/1
4 years, 7 months ago (2016-05-09 17:29:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 17:29:44 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 17:31:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b466adfe47368737c0ed2e48a96c85e46a7d5f4d
Cr-Commit-Position: refs/heads/master@{#36115}

Powered by Google App Engine
This is Rietveld 408576698