Issue 19601006: put max on outputted poi in skpdiff

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19601006: put max on outputted poi in skpdiff (Closed)

Created:
7 years, 5 months ago by Zach Reizner

Modified:
7 years, 5 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

put max on outputted poi in skpdiff R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10262

Patch Set 2 : document #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	tools/skpdiff/SkDiffContext.cpp	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Zach Reizner

If I output too many poi's, the JSON file get so large that the viewer ...

7 years, 5 months ago (2013-07-22 21:09:36 UTC) #1

djsollen

lgtm https://codereview.chromium.org/19601006/diff/1/tools/skpdiff/SkDiffContext.cpp File tools/skpdiff/SkDiffContext.cpp (right): https://codereview.chromium.org/19601006/diff/1/tools/skpdiff/SkDiffContext.cpp#newcode18 tools/skpdiff/SkDiffContext.cpp:18: static const int kMaxPOI = 100; document that ...

7 years, 5 months ago (2013-07-23 12:28:29 UTC) #2

Zach Reizner

7 years, 5 months ago (2013-07-23 12:57:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r10262 (presubmit successful).

Expand Messages | Collapse Messages

Issue 19601006: put max on outputted poi in skpdiff (Closed)

Description

Patch Set 1 #

Patch Set 2 : document #

Messages