Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1960083002: [fullcodegen] Add missing bailout points for super calls. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 2311 matching lines...) Expand 10 before | Expand all | Expand 10 after
2322 PushOperand(eax); 2322 PushOperand(eax);
2323 PushOperand(Operand(esp, kPointerSize * 2)); 2323 PushOperand(Operand(esp, kPointerSize * 2));
2324 PushOperand(key->value()); 2324 PushOperand(key->value());
2325 // Stack here: 2325 // Stack here:
2326 // - home_object 2326 // - home_object
2327 // - this (receiver) 2327 // - this (receiver)
2328 // - this (receiver) <-- LoadFromSuper will pop here and below. 2328 // - this (receiver) <-- LoadFromSuper will pop here and below.
2329 // - home_object 2329 // - home_object
2330 // - key 2330 // - key
2331 CallRuntimeWithOperands(Runtime::kLoadFromSuper); 2331 CallRuntimeWithOperands(Runtime::kLoadFromSuper);
2332 PrepareForBailoutForId(prop->LoadId(), TOS_REG);
2332 2333
2333 // Replace home_object with target function. 2334 // Replace home_object with target function.
2334 __ mov(Operand(esp, kPointerSize), eax); 2335 __ mov(Operand(esp, kPointerSize), eax);
2335 2336
2336 // Stack here: 2337 // Stack here:
2337 // - target function 2338 // - target function
2338 // - this (receiver) 2339 // - this (receiver)
2339 EmitCall(expr); 2340 EmitCall(expr);
2340 } 2341 }
2341 2342
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
2378 PushOperand(eax); 2379 PushOperand(eax);
2379 PushOperand(Operand(esp, kPointerSize * 2)); 2380 PushOperand(Operand(esp, kPointerSize * 2));
2380 VisitForStackValue(prop->key()); 2381 VisitForStackValue(prop->key());
2381 // Stack here: 2382 // Stack here:
2382 // - home_object 2383 // - home_object
2383 // - this (receiver) 2384 // - this (receiver)
2384 // - this (receiver) <-- LoadKeyedFromSuper will pop here and below. 2385 // - this (receiver) <-- LoadKeyedFromSuper will pop here and below.
2385 // - home_object 2386 // - home_object
2386 // - key 2387 // - key
2387 CallRuntimeWithOperands(Runtime::kLoadKeyedFromSuper); 2388 CallRuntimeWithOperands(Runtime::kLoadKeyedFromSuper);
2389 PrepareForBailoutForId(prop->LoadId(), TOS_REG);
2388 2390
2389 // Replace home_object with target function. 2391 // Replace home_object with target function.
2390 __ mov(Operand(esp, kPointerSize), eax); 2392 __ mov(Operand(esp, kPointerSize), eax);
2391 2393
2392 // Stack here: 2394 // Stack here:
2393 // - target function 2395 // - target function
2394 // - this (receiver) 2396 // - this (receiver)
2395 EmitCall(expr); 2397 EmitCall(expr);
2396 } 2398 }
2397 2399
(...skipping 1465 matching lines...) Expand 10 before | Expand all | Expand 10 after
3863 isolate->builtins()->OnStackReplacement()->entry(), 3865 isolate->builtins()->OnStackReplacement()->entry(),
3864 Assembler::target_address_at(call_target_address, unoptimized_code)); 3866 Assembler::target_address_at(call_target_address, unoptimized_code));
3865 return ON_STACK_REPLACEMENT; 3867 return ON_STACK_REPLACEMENT;
3866 } 3868 }
3867 3869
3868 3870
3869 } // namespace internal 3871 } // namespace internal
3870 } // namespace v8 3872 } // namespace v8
3871 3873
3872 #endif // V8_TARGET_ARCH_IA32 3874 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698