Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 1960053002: Revert of [test] Skip failing test after clang roll. (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
Reviewers:
titzer, Nico
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [test] Skip failing test after clang roll. (patchset #1 id:1 of https://codereview.chromium.org/1955013002/ ) Reason for revert: Clang roll with fix is in. Original issue's description: > [test] Skip failing test after clang roll. > > BUG=v8:4995 > LOG=n > NOTRY=true > TBR=thakis@chromium.org, titzer@chromium.org > > Committed: https://crrev.com/6e6a7ea3a425bee65d856814bd361ddbf14811f5 > Cr-Commit-Position: refs/heads/master@{#36064} TBR=thakis@chromium.org,titzer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4995 NOTRY=true LOG=n Committed: https://crrev.com/a0f91c6ad0bb3fbb0dfe4e06143fc3ccab6f500c Cr-Commit-Position: refs/heads/master@{#36119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M test/unittests/unittests.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Michael Achenbach
Created Revert of [test] Skip failing test after clang roll.
4 years, 7 months ago (2016-05-09 08:52:47 UTC) #1
Nico
lgtm
4 years, 7 months ago (2016-05-09 13:35:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960053002/1
4 years, 7 months ago (2016-05-09 13:35:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14850)
4 years, 7 months ago (2016-05-09 13:38:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960053002/1
4 years, 7 months ago (2016-05-09 20:08:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 20:10:42 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 20:12:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0f91c6ad0bb3fbb0dfe4e06143fc3ccab6f500c
Cr-Commit-Position: refs/heads/master@{#36119}

Powered by Google App Engine
This is Rietveld 408576698