Fix some misc nits.

Fix some misc nits.

These were left over from after I broke a big "things that never return
NULL" CL up into smaller ones.

Committed: https://pdfium.googlesource.com/pdfium/+/594b20b485046c954b68734e63e8d2c93fbe4ef5

[Lei Zhang, 2016-05-10 07:19:00]

Description was changed from

==========
Simplify many if statements that always evaulates to true.
==========

to

==========
Simplify many if statements that always evaluates to true.

- IFX_Edit::NewEdit() never returns NULL.
- IFX_Edit::GetIterator() never returns NULL.
- CPDF_VariableText::GetIterator() never returns NULL.
- CPVT_GenerateAP::GenerateEditAP() has a param that's always NULL.

123456789012345678901234567890123456789012345678901234567890123456789012

Additionally:
- No caller checks the CPDF_VariableText::SetProvider() return value.
- IFX_Edit::SetVTProvider() is unused.
- CFX_ListItem::SetCaret() is useless.
- CFX_List::SetItemCaret() is also useless.
==========

[Lei Zhang, 2016-05-10 07:19:10]

Description was changed from

==========
Simplify many if statements that always evaluates to true.

- IFX_Edit::NewEdit() never returns NULL.
- IFX_Edit::GetIterator() never returns NULL.
- CPDF_VariableText::GetIterator() never returns NULL.
- CPVT_GenerateAP::GenerateEditAP() has a param that's always NULL.

123456789012345678901234567890123456789012345678901234567890123456789012

Additionally:
- No caller checks the CPDF_VariableText::SetProvider() return value.
- IFX_Edit::SetVTProvider() is unused.
- CFX_ListItem::SetCaret() is useless.
- CFX_List::SetItemCaret() is also useless.
==========

to

==========
Simplify many if statements that always evaluates to true.

- IFX_Edit::NewEdit() never returns NULL.
- IFX_Edit::GetIterator() never returns NULL.
- CPDF_VariableText::GetIterator() never returns NULL.
- CPVT_GenerateAP::GenerateEditAP() has a param that's always NULL.

Additionally:
- No caller checks the CPDF_VariableText::SetProvider() return value.
- IFX_Edit::SetVTProvider() is unused.
- CFX_ListItem::SetCaret() is useless.
- CFX_List::SetItemCaret() is also useless.
==========

[Lei Zhang, 2016-05-12 19:55:35]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2016-05-12 19:57:20]

Description was changed from

==========
Simplify many if statements that always evaluates to true.

- IFX_Edit::NewEdit() never returns NULL.
- IFX_Edit::GetIterator() never returns NULL.
- CPDF_VariableText::GetIterator() never returns NULL.
- CPVT_GenerateAP::GenerateEditAP() has a param that's always NULL.

Additionally:
- No caller checks the CPDF_VariableText::SetProvider() return value.
- IFX_Edit::SetVTProvider() is unused.
- CFX_ListItem::SetCaret() is useless.
- CFX_List::SetItemCaret() is also useless.
==========

to

==========
Fix some misc nits.

These were left over from after I broke a big "things that never return
NULL" CL up into smaller ones.
==========

[Lei Zhang, 2016-05-12 19:57:20]

thestig@chromium.org changed reviewers:
+ weili@chromium.org

[Wei Li, 2016-05-12 21:11:59]

lgtm (with fix for the below)

https://codereview.chromium.org/1960043003/diff/20001/core/fpdfdoc/cpdf_varia...
File core/fpdfdoc/cpdf_variabletext.cpp (right):

https://codereview.chromium.org/1960043003/diff/20001/core/fpdfdoc/cpdf_varia...
core/fpdfdoc/cpdf_variabletext.cpp:1115: uint16_t word = SubWord ? SubWord :
Word;
SubWord > 0 ? SubWord : Word

[Lei Zhang, 2016-05-12 22:11:32]

https://codereview.chromium.org/1960043003/diff/20001/core/fpdfdoc/cpdf_varia...
File core/fpdfdoc/cpdf_variabletext.cpp (right):

https://codereview.chromium.org/1960043003/diff/20001/core/fpdfdoc/cpdf_varia...
core/fpdfdoc/cpdf_variabletext.cpp:1115: uint16_t word = SubWord ? SubWord :
Word;
On 2016/05/12 21:11:59, Wei Li wrote:
> SubWord > 0 ? SubWord : Word

|SubWord| is unsigned, so it doesn't matter?

[Lei Zhang, 2016-05-13 04:51:03]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-05-13 04:51:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960043003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960043003/20001

[commit-bot: I haz the power, 2016-05-13 04:56:48]

Description was changed from

==========
Fix some misc nits.

These were left over from after I broke a big "things that never return
NULL" CL up into smaller ones.
==========

to

==========
Fix some misc nits.

These were left over from after I broke a big "things that never return
NULL" CL up into smaller ones.

Committed:
https://pdfium.googlesource.com/pdfium/+/594b20b485046c954b68734e63e8d2c93fbe...
==========

[commit-bot: I haz the power, 2016-05-13 04:56:49]

Committed patchset #1 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/594b20b485046c954b68734e63e8d2c93fbe...