Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1960043002: [turbofan] Remove deprecated --turbo-osr flag. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove deprecated --turbo-osr flag. The flag in question used to fall-back to Crankshaft whenever an OSR request couldn't be handled by TurboFan. By now OSR in TurboFan is sufficiently stabilized that one single --use-osr flag should do it. R=titzer@chromium.org Committed: https://crrev.com/434ef2ccfdcac93077a16a0cd88fd5ac012a0d79 Cr-Commit-Position: refs/heads/master@{#36102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -58 lines) Patch
M src/compiler.cc View 4 chunks +4 lines, -21 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M test/mjsunit/compiler/osr-alignment.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-backedges1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-block-scope.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-block-scope-func.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-block-scope-id.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-follow.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-for-let.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-forin.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-forin-nested.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-forof.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-function.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-function-id.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-function-id2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-infinite.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-labeled.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-literals.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-literals-adapted.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-manual1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-manual2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-multiple.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-multiple2.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/compiler/osr-multiple3.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/compiler/osr-nested2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-nested2b.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-nested3.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-nested3b.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-regex-id.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-sar.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-warm.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/osr-while-let.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/try-osr.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-480807.js View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-09 08:42:00 UTC) #1
titzer
lgtm
4 years, 7 months ago (2016-05-09 08:45:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960043002/1
4 years, 7 months ago (2016-05-09 08:47:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 09:10:25 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 09:12:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/434ef2ccfdcac93077a16a0cd88fd5ac012a0d79
Cr-Commit-Position: refs/heads/master@{#36102}

Powered by Google App Engine
This is Rietveld 408576698