Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 196003003: remove SK_SUPPORT_LEGACY_COPYTO_CONFIG (Closed)

Created:
6 years, 9 months ago by reed2
Modified:
6 years, 9 months ago
Reviewers:
hal.canary
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

remove SK_SUPPORT_LEGACY_COPYTO_CONFIG TBR=halcanary@google.com NOTRY=True NOTREECHECK=True Committed: http://code.google.com/p/skia/source/detail?r=13753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
reed2
The CQ bit was checked by reed@chromium.org
6 years, 9 months ago (2014-03-11 22:43:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/196003003/1
6 years, 9 months ago (2014-03-11 22:43:24 UTC) #2
reed2
The CQ bit was unchecked by reed@chromium.org
6 years, 9 months ago (2014-03-11 22:43:56 UTC) #3
reed2
The CQ bit was checked by reed@chromium.org
6 years, 9 months ago (2014-03-11 22:43:59 UTC) #4
reed2
Hal, can this make it for the DEPS roll?
6 years, 9 months ago (2014-03-11 22:46:49 UTC) #5
reed2
6 years, 9 months ago (2014-03-11 22:47:03 UTC) #6
hal.canary
On 2014/03/11 22:46:49, reed2 wrote: > Hal, can this make it for the DEPS roll? ...
6 years, 9 months ago (2014-03-11 22:51:03 UTC) #7
hal.canary
LGTM, modulo breaking the chrome build.
6 years, 9 months ago (2014-03-11 22:54:32 UTC) #8
hal.canary
The CQ bit was unchecked by halcanary@google.com
6 years, 9 months ago (2014-03-11 22:57:23 UTC) #9
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 9 months ago (2014-03-11 22:57:25 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 22:58:03 UTC) #11
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-11 22:58:04 UTC) #12
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 9 months ago (2014-03-11 22:58:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/196003003/1
6 years, 9 months ago (2014-03-11 22:58:16 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 22:58:26 UTC) #15
Message was sent while issue was closed.
Change committed as 13753

Powered by Google App Engine
This is Rietveld 408576698