Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 1960013002: Use correct creation context during Iterable.forEach iteration (Closed)

Created:
4 years, 2 months ago by Jens Widell
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Use correct creation context during Iterable.forEach iteration Use |thisValue| instead of |scriptState->context()->Global()|, since this is simpler and since Global() actually returns a WindowProxy object that may change and become incorrect to use as creation context depending on what the callback function does. BUG=605910 Review URL: https://codereview.chromium.org/1918763002 Cr-Commit-Position: refs/heads/master@{#389785} (cherry picked from commit 0cd7a9f853e3cb7c035b4ab9e07a503552267f9d) Committed: https://chromium.googlesource.com/chromium/src/+/cfb182b8d5cdc104ba1e9c09125c918b00e850bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css/fontfaceset-cross-frame.html View 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/Iterable.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Jens Widell
4 years, 2 months ago (2016-05-09 06:50:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cfb182b8d5cdc104ba1e9c09125c918b00e850bb (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698