Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 195993009: Generate better isFooElement() helper functions for HTML Elements (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
esprehn, adamk, eseidel
CC:
adamk+blink_chromium.org, blink-reviews, dglazkov+blink
Visibility:
Public.

Description

Generate better isFooElement() helper functions for HTML Elements Generate better isFooElement() helper functions for HTML Elements. Specialize HTML element type checking helpers to only compare the localName and not the fully qualified tag name as this is sufficient and a little bit faster. This is based on the following WebKit revision by <akling@apple.com>;: http://trac.webkit.org/changeset/157343 R=esprehn, adamk, eseidel BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M Source/build/scripts/templates/ElementTypeHelpers.h.tmpl View 2 chunks +21 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.h View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Inactive
6 years, 9 months ago (2014-03-13 21:50:35 UTC) #1
esprehn
lgtm
6 years, 9 months ago (2014-03-13 22:04:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/195993009/1
6 years, 9 months ago (2014-03-13 22:04:41 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 22:23:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_blink_rel
6 years, 9 months ago (2014-03-13 22:23:50 UTC) #5
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-13 23:09:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/195993009/1
6 years, 9 months ago (2014-03-13 23:09:52 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 23:23:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_blink_rel
6 years, 9 months ago (2014-03-13 23:23:17 UTC) #9
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-14 00:29:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/195993009/1
6 years, 9 months ago (2014-03-14 00:29:45 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 01:03:20 UTC) #12
Message was sent while issue was closed.
Change committed as 169187

Powered by Google App Engine
This is Rietveld 408576698