Factor out GamepadCommon base class from Gamepad and WebKitGamepad

Source/modules/gamepad/GamepadList.h

Index: Source/modules/gamepad/GamepadList.h
diff --git a/Source/modules/gamepad/GamepadList.h b/Source/modules/gamepad/GamepadList.h
index b19e6afc5c042d2e2ff471da76bf39ceb9734733..7f2e714d19a3186e962e69b5136dcb3bad88922c 100644
--- a/Source/modules/gamepad/GamepadList.h
+++ b/Source/modules/gamepad/GamepadList.h
@@ -36,23 +36,22 @@
 
 namespace WebCore {
 
-class GamepadList : public RefCountedWillBeGarbageCollectedFinalized<GamepadList>, public ScriptWrappable {
+class GamepadList FINAL : public RefCountedWillBeGarbageCollectedFinalized<GamepadList>, public ScriptWrappable {
 public:
-    static PassRefPtrWillBeRawPtr<GamepadList> create() { return adoptRefWillBeNoop(new GamepadList); }
-    ~GamepadList();
+    static PassRefPtrWillBeRawPtr<GamepadList> create()
+    {
+        return adoptRefWillBeNoop(new GamepadList);
+    }
+    ~GamepadList() { }

[zerny-chromium, 2014/03/13 09:48:00]

Nit: keep the impl in the cpp file.

[Nils Barth (inactive), 2014/03/13 12:51:14]

Done.

 
     void set(unsigned index, PassRefPtrWillBeRawPtr<Gamepad>);
     Gamepad* item(unsigned index);
-    unsigned length() const;
+    unsigned length() const { return blink::WebGamepads::itemsLengthCap; }
 
     void trace(Visitor*);
 
 private:
-    GamepadList()
-    {
-        ScriptWrappable::init(this);
-    }
-
+    GamepadList() { ScriptWrappable::init(this); }
     RefPtrWillBeMember<Gamepad> m_items[blink::WebGamepads::itemsLengthCap];

[zerny-chromium, 2014/03/13 09:48:00]

Could we just use a HeapVector here. Maybe replace GamepadList by a vector
completely? Or is the list class an API element?

[Nils Barth (inactive), 2014/03/13 12:51:14]

? (I'm just refactoring here; how would a HeapVector work?)
(It's currently a 4 element array, FWIW.)
GamepadList is an API element (see GamepadList.idl),
so we need it.

 };