Issue 19599013: Fix break for devices with no IMEI .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19599013: Fix break for devices with no IMEI . (Closed)

Created:
7 years, 5 months ago by navabi

Modified:
7 years, 5 months ago

Reviewers:
johnw, Isaac (away), bulach, Siva Chandra

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix break for devices with no IMEI . Fixes failure for devices without IMEI (e.g. nakasi). build/android/buildbot/bb_device_status_check.py Traceback (most recent call last): File "build/android/buildbot/bb_device_status_check.py", line 247, in <module> sys.exit(main()) File "build/android/buildbot/bb_device_status_check.py", line 204, in main zip(*[DeviceInfo(dev, options) for dev in devices])) File "build/android/buildbot/bb_device_status_check.py", line 62, in DeviceInfo imei_slice = re.findall('Device ID = (\d+)', sub_info)[0][-6:] IndexError: list index out of range BUG=

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	build/android/buildbot/bb_device_status_check.py	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

navabi

7 years, 5 months ago (2013-07-24 16:29:48 UTC) #1

Message was sent while issue was closed.

Abandoned. Marcus committed a fix:
https://chromiumcodereview.appspot.com/19981006/

Expand Messages | Collapse Messages