net/url_request/url_request_status.h - Issue 19599012: Add detailed histograms for DownloadProtectionService URLFetcher errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_status.h

Issue 19599012: Add detailed histograms for DownloadProtectionService URLFetcher errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/download_protection_service.cc ('K') | « chrome/browser/ui/webui/net_internals/net_internals_ui.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_status.h

diff --git a/net/url_request/url_request_status.h b/net/url_request/url_request_status.h

index 521a3d45f5fa94b043e9c4a12ac7a5bce99386f2..ce9e33d085fcf87a3e5488465ae1487c75c41381 100644

--- a/net/url_request/url_request_status.h

+++ b/net/url_request/url_request_status.h

@@ -27,6 +27,10 @@ class URLRequestStatus {

// The request failed for some reason. |error_| may have more information.

FAILED,

+ // So that Status enums can be used in histograms, always add new values

+ // before this one, and do not change existing values.

+ STATUS_MAX

mattm 2013/07/24 02:19:00 any objections to this?

mmenke 2013/07/24 14:26:50 Nope, I'm fine with it... But I'm not sure we nee

};

URLRequestStatus() : status_(SUCCESS), error_(0) {}