dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart - Issue 19599007: Implement reflection on native classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

Issue 19599007: Implement reflection on native classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Mark test as failing on VM (requires browser) Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('K') | « dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | dart/tests/lib/lib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

index 6538cf2dfdaa25d8f440173321c8a5055a0d530c..84aa5106c5e068b5dea5b7390fd56cdc6cb92dac 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

@@ -238,8 +238,9 @@ class NativeEmitter {

jsAst.Expression init =

karlklose 2013/07/19 09:29:40 This expression is no longer used, as far as I see

ahe 2013/07/19 10:00:00 Done.

js(emitter.classesCollector)[className].assign(

builder.toObjectInitializer());

- mainBuffer.write(jsAst.prettyPrint(init, compiler));

- mainBuffer.write('$N$n');

+ emitter.emitClassBuilderWithReflectionData(

+ className, classElement, builder,

+ emitter.bufferForElement(classElement, mainBuffer));

emitter.needsDefineClass = true;

}