Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Issue 195983002: Reland "Pass a Code object to Assembler::(set_)target_address_at for use by ool constant pool." (Closed)

Created:
6 years, 9 months ago by rmcilroy
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Reland "Pass a Code object to Assembler::(set_)target_address_at for use by ool constant pool." The ool constant pool will require a pointer to the code's constant pool when updating or reading target addresses using set_target_address_at() and target_address_at(). Original Review URL: https://codereview.chromium.org/183803022 R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19856

Patch Set 1 #

Patch Set 2 : Fix ia32 and x64 bug/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -118 lines) Patch
M src/a64/assembler-a64.h View 2 chunks +10 lines, -3 lines 0 comments Download
M src/a64/assembler-a64-inl.h View 9 chunks +30 lines, -12 lines 0 comments Download
M src/a64/frames-a64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.h View 2 chunks +21 lines, -3 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 8 chunks +14 lines, -10 lines 0 comments Download
M src/debug.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/disassembler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/assembler-ia32.h View 1 2 chunks +17 lines, -4 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 5 chunks +12 lines, -9 lines 0 comments Download
M src/ia32/frames-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ic.h View 11 chunks +47 lines, -14 lines 0 comments Download
M src/ic.cc View 10 chunks +73 lines, -33 lines 0 comments Download
M src/ic-inl.h View 4 chunks +54 lines, -7 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects-visiting-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/serialize.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 1 2 chunks +17 lines, -4 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 5 chunks +10 lines, -7 lines 0 comments Download
M src/x64/frames-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
Original CL in patch set 1, fixes in set 2. PTAL.
6 years, 9 months ago (2014-03-11 22:50:58 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-12 10:27:11 UTC) #2
rmcilroy
6 years, 9 months ago (2014-03-12 15:24:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19856 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698