Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1959783002:
DevTools: Introduce device dependent CPU throttling rates. (Closed)
|
Created:
4 years, 7 months ago by alph Modified:
4 years, 7 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Introduce device dependent CPU throttling rates.
NOTRY=true
BUG=436111
Committed: https://crrev.com/5f1d704d671ca80af36a67c6899ab846b2397254
Cr-Commit-Position: refs/heads/master@{#392277}
Patch Set 1 #
Total comments: 4
Patch Set 2 : addressing comments. #Patch Set 3 : #Messages
Total messages: 24 (11 generated)
alph@chromium.org changed reviewers: + paulirish@chromium.org, pfeldman@chromium.org
I don't think we should go into the business of estimating phone performance - it is unlikely that it produces anything close to the reality. I would rather introduce two options: high end device and low end device and would throttle everything 3x and 10x for them. That would be as accurate as what you deliver, yet simpler. https://codereview.chromium.org/1959783002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json (right): https://codereview.chromium.org/1959783002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json:316: "octane-score": 8083, I wonder if we can use this: http://www.phonearena.com/phones/benchmarks https://codereview.chromium.org/1959783002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js (right): https://codereview.chromium.org/1959783002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js:22: this._createOctaneScoreInput(); Lets do that later.
ptal https://codereview.chromium.org/1959783002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json (right): https://codereview.chromium.org/1959783002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json:316: "octane-score": 8083, On 2016/05/06 23:13:09, pfeldman wrote: > I wonder if we can use this: http://www.phonearena.com/phones/benchmarks I'll try to in the upcoming patches. https://codereview.chromium.org/1959783002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js (right): https://codereview.chromium.org/1959783002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js:22: this._createOctaneScoreInput(); On 2016/05/06 23:13:09, pfeldman wrote: > Lets do that later. ok
lgtm
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959783002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959783002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959783002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== DevTools: Introduce device dependent CPU throttling rates. BUG=436111 ========== to ========== DevTools: Introduce device dependent CPU throttling rates. NOTRY=true BUG=436111 ==========
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959783002/40001
Message was sent while issue was closed.
Description was changed from ========== DevTools: Introduce device dependent CPU throttling rates. NOTRY=true BUG=436111 ========== to ========== DevTools: Introduce device dependent CPU throttling rates. NOTRY=true BUG=436111 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: Introduce device dependent CPU throttling rates. NOTRY=true BUG=436111 ========== to ========== DevTools: Introduce device dependent CPU throttling rates. NOTRY=true BUG=436111 Committed: https://crrev.com/5f1d704d671ca80af36a67c6899ab846b2397254 Cr-Commit-Position: refs/heads/master@{#392277} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/5f1d704d671ca80af36a67c6899ab846b2397254 Cr-Commit-Position: refs/heads/master@{#392277} |
