Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 195973007: Fix GPU displacement with expanding crop rects. (Closed)

Created:
6 years, 9 months ago by Stephen White
Modified:
6 years, 9 months ago
Reviewers:
epoger, Justin Novosad
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix GPU displacement with expanding crop rects. Fix GPU displacement with expanding crop rects, and re-enable the imagefilterscropexpand GM. There were two bugs: the result texture was being created at input color bitmap size, not the cropped bounds size, and the matrix in GrContext was not being set to identity before draw. R=junov@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=13844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M gyp/gmslides.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Stephen White
junov@: PTAL. Thanks!
6 years, 9 months ago (2014-03-17 22:05:24 UTC) #1
Justin Novosad
On 2014/03/17 22:05:24, Stephen White wrote: > junov@: PTAL. Thanks! lgtm
6 years, 9 months ago (2014-03-17 22:08:00 UTC) #2
Stephen White
Committed patchset #1 manually as r13844 (presubmit successful).
6 years, 9 months ago (2014-03-17 23:41:52 UTC) #3
epoger
FYI: This CL triggered a strange failure on a single Android buildbot. See https://code.google.com/p/skia/issues/detail?id=2313 ('Test-Android-Nexus10-MaliT604-Arm7-Release ...
6 years, 9 months ago (2014-03-19 21:43:42 UTC) #4
epoger
6 years, 9 months ago (2014-03-21 19:02:30 UTC) #5
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/208843002/ by epoger@google.com.

The reason for reverting is: Speculative revert (for trybot consumption) per
https://code.google.com/p/skia/issues/detail?id=2313#c13.

Powered by Google App Engine
This is Rietveld 408576698