Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8447)

Unified Diff: chrome/renderer/extensions/chrome_v8_context.cc

Issue 195973002: Change DCHECK_IS_ON() to DCHECK_IS_ON (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Keep a comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/shell_util.cc ('k') | chrome/renderer/extensions/chrome_v8_context_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/chrome_v8_context.cc
diff --git a/chrome/renderer/extensions/chrome_v8_context.cc b/chrome/renderer/extensions/chrome_v8_context.cc
index cb3b06831fb09345fae3d1221eeb6c1885789033..e94d0197a5fdb4005d6351e157881de9960c711e 100644
--- a/chrome/renderer/extensions/chrome_v8_context.cc
+++ b/chrome/renderer/extensions/chrome_v8_context.cc
@@ -173,12 +173,8 @@ void ChromeV8Context::OnResponseReceived(const std::string& name,
// In debug, the js will validate the callback parameters and return a
// string if a validation error has occured.
- if (DCHECK_IS_ON()) {
- if (!retval.IsEmpty() && !retval->IsUndefined()) {
- std::string error = *v8::String::Utf8Value(retval);
- DCHECK(false) << error;
- }
- }
+ DCHECK(retval.IsEmpty() || retval->IsUndefined())
+ << *v8::String::Utf8Value(retval);
}
} // namespace extensions
« no previous file with comments | « chrome/installer/util/shell_util.cc ('k') | chrome/renderer/extensions/chrome_v8_context_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698