Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2188)

Unified Diff: base/prefs/pref_registry.cc

Issue 195973002: Change DCHECK_IS_ON() to DCHECK_IS_ON (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Keep a comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/histogram.h ('k') | cc/layers/delegated_frame_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/pref_registry.cc
diff --git a/base/prefs/pref_registry.cc b/base/prefs/pref_registry.cc
index 9d6b05c836259e3e59a6bc9bc568ad9bdc481d6b..134996185c4dd593709a8085b701d8ce10020d10 100644
--- a/base/prefs/pref_registry.cc
+++ b/base/prefs/pref_registry.cc
@@ -31,13 +31,11 @@ PrefRegistry::const_iterator PrefRegistry::end() const {
void PrefRegistry::SetDefaultPrefValue(const char* pref_name,
base::Value* value) {
DCHECK(value);
- if (DCHECK_IS_ON()) {
- const base::Value* current_value = NULL;
- DCHECK(defaults_->GetValue(pref_name, &current_value))
- << "Setting default for unregistered pref: " << pref_name;
- DCHECK(value->IsType(current_value->GetType()))
- << "Wrong type for new default: " << pref_name;
- }
+ const base::Value* current_value = NULL;
+ DCHECK(defaults_->GetValue(pref_name, &current_value))
+ << "Setting default for unregistered pref: " << pref_name;
+ DCHECK(value->IsType(current_value->GetType()))
+ << "Wrong type for new default: " << pref_name;
defaults_->ReplaceDefaultValue(pref_name, make_scoped_ptr(value));
}
« no previous file with comments | « base/metrics/histogram.h ('k') | cc/layers/delegated_frame_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698