Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3940)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/logging_chrome.cc

Issue 195973002: Change DCHECK_IS_ON() to DCHECK_IS_ON (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: if() -> #if Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/top_sites_cache.cc ('k') | chrome/installer/util/shell_util.cc » ('j') | content/common/gpu/media/gpu_video_decode_accelerator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/logging_chrome.cc
diff --git a/chrome/common/logging_chrome.cc b/chrome/common/logging_chrome.cc
index be0ddffa1c533bd6c7ab46dd284cb54349a14752..a0b53f09c8dfc70380d936a1904374766f5f56ff 100644
--- a/chrome/common/logging_chrome.cc
+++ b/chrome/common/logging_chrome.cc
@@ -358,13 +358,10 @@ void InitChromeLogging(const CommandLine& command_line,
logging::LogEventProvider::Initialize(kChromeTraceProviderName);
#endif
-#ifdef NDEBUG
- if (command_line.HasSwitch(switches::kSilentDumpOnDCHECK) && DCHECK_IS_ON()) {
-#if defined(OS_WIN)
+#if DCHECK_IS_ON && defined(NDEBUG) && defined(OS_WIN)
+ if (command_line.HasSwitch(switches::kSilentDumpOnDCHECK))
logging::SetLogReportHandler(DumpProcessAssertHandler);
#endif
- }
-#endif // NDEBUG
chrome_logging_initialized_ = true;
}
« no previous file with comments | « chrome/browser/history/top_sites_cache.cc ('k') | chrome/installer/util/shell_util.cc » ('j') | content/common/gpu/media/gpu_video_decode_accelerator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698