chrome/renderer/extensions/chrome_v8_context.cc - Issue 195973002: Change DCHECK_IS_ON() to DCHECK_IS_ON

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/chrome_v8_context.cc

Issue 195973002: Change DCHECK_IS_ON() to DCHECK_IS_ON (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/chrome_v8_context.cc

diff --git a/chrome/renderer/extensions/chrome_v8_context.cc b/chrome/renderer/extensions/chrome_v8_context.cc

index cb3b06831fb09345fae3d1221eeb6c1885789033..909b6e5a6769ef19b29c6d4280719c7f9a47ee44 100644

--- a/chrome/renderer/extensions/chrome_v8_context.cc

+++ b/chrome/renderer/extensions/chrome_v8_context.cc

@@ -173,7 +173,7 @@ void ChromeV8Context::OnResponseReceived(const std::string& name,

// In debug, the js will validate the callback parameters and return a

// string if a validation error has occured.

- if (DCHECK_IS_ON()) {

+ if (DCHECK_IS_ON) {

if (!retval.IsEmpty() && !retval->IsUndefined()) {

std::string error = *v8::String::Utf8Value(retval);

DCHECK(false) << error;