Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1959653002: MIPS: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm m… (Closed)

Created:
4 years, 7 months ago by akos.palfi.imgtec
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory size references in generated code. Port 117a56b7c2a88ab2b2f25fad88517d72f5edbac9 BUG= Committed: https://crrev.com/2c6d0789c8d8abbe40f57d93a675bdb3cda91677 Cr-Commit-Position: refs/heads/master@{#36081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
akos.palfi.imgtec
PTAL.
4 years, 7 months ago (2016-05-06 12:42:24 UTC) #2
balazs.kilvady
lgtm
4 years, 7 months ago (2016-05-06 12:52:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959653002/1
4 years, 7 months ago (2016-05-06 12:53:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 13:25:33 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 13:27:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c6d0789c8d8abbe40f57d93a675bdb3cda91677
Cr-Commit-Position: refs/heads/master@{#36081}

Powered by Google App Engine
This is Rietveld 408576698