Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 1959643002: [Mac] Work around potential pthread_mutex_destroy crashes (Closed)

Created:
4 years, 7 months ago by Jakob Kummerow
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Mac] Work around potential pthread_mutex_destroy crashes This ports https://codereview.chromium.org/1323293005 to V8. I'm not aware of any evidence that such crashes are currently happening, but it's probably good to ship this workaround anyway. BUG=chromium:517681 LOG=n Committed: https://crrev.com/fd2dbf1d0124b8c1212226ccb668259b8eac7ff8 Cr-Commit-Position: refs/heads/master@{#36087}

Patch Set 1 #

Patch Set 2 : fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/base/platform/condition-variable.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jakob Kummerow
Please take a look. It appears V8 uses the terms "Mutex" and "LockGuard" for what ...
4 years, 7 months ago (2016-05-06 13:13:32 UTC) #2
erikchen
lgtm
4 years, 7 months ago (2016-05-06 16:00:38 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-06 16:41:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959643002/20001
4 years, 7 months ago (2016-05-06 16:53:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-06 17:21:08 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 17:22:14 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd2dbf1d0124b8c1212226ccb668259b8eac7ff8
Cr-Commit-Position: refs/heads/master@{#36087}

Powered by Google App Engine
This is Rietveld 408576698