Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1959623002: Move line-specific parts of addOutlineRects() into LayoutBlockFlow. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move line-specific parts of addOutlineRects() into LayoutBlockFlow. BUG=302024 Committed: https://crrev.com/f8e303b117730ca7dafbbdcb7777176c89a7020e Cr-Commit-Position: refs/heads/master@{#392137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -31 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +1 line, -31 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-06 13:13:49 UTC) #2
wkorman
lgtm
4 years, 7 months ago (2016-05-06 18:39:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959623002/1
4 years, 7 months ago (2016-05-06 19:12:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 20:29:11 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 20:30:25 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f8e303b117730ca7dafbbdcb7777176c89a7020e
Cr-Commit-Position: refs/heads/master@{#392137}

Powered by Google App Engine
This is Rietveld 408576698