Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1959603002: Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. (patchset #2 id:20001 of https://codereview.chromium.org/1948453002/ ) Reason for revert: Breaks WASM; please also add tests when relanding. Original issue's description: > [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. > > Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a memory operand if the load representation machine size is wide enough to represent the latter. > > Committed: https://crrev.com/a0543313dbd46b0c2e72c91ee3488a7dc6db73e4 > Cr-Commit-Position: refs/heads/master@{#36009} TBR=bmeurer@chromium.org,jfb@chromium.org,epertoso@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/3b7ff999f3a9b33945b77787ba85251e42939ac0 Cr-Commit-Position: refs/heads/master@{#36066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -132 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 3 chunks +14 lines, -59 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 4 chunks +17 lines, -73 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
titzer
4 years, 7 months ago (2016-05-06 07:49:50 UTC) #1
Created Revert of [turbofan] Take the immediate size in account when narrowing
ia32/x64 word comparison operators.

Powered by Google App Engine
This is Rietveld 408576698