chrome/browser/translate/translate_infobar_delegate.h - Issue 19596002: [Translate] Return before the new delegate is created if needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_infobar_delegate.h

Issue 19596002: [Translate] Return before the new delegate is created if needed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/translate/translate_infobar_delegate.h

diff --git a/chrome/browser/translate/translate_infobar_delegate.h b/chrome/browser/translate/translate_infobar_delegate.h

index b934d32154a2afec41c7c9d15b6b93a58a6108bc..348c3d675269e7441cf67b31ea1bd61171c50756 100644

--- a/chrome/browser/translate/translate_infobar_delegate.h

+++ b/chrome/browser/translate/translate_infobar_delegate.h

@@ -58,7 +58,7 @@ class TranslateInfoBarDelegate : public InfoBarDelegate {

// If |replace_existing_infobar| is true, the infobar is created and added to

// |infobar_service|, replacing any other translate infobar already present

// there. Otherwise, the infobar will only be added if there is no other

- // translate infobar already present.

+ // translate infobar already present and if the infobar needs to be displayed.

Peter Kasting 2013/07/17 18:06:19 Nit: Don't make this change; it's somewhat inaccur

static void Create(InfoBarService* infobar_service,

bool replace_existing_infobar,

Type infobar_type,

« no previous file with comments | « no previous file | chrome/browser/translate/translate_infobar_delegate.cc » ('j') | chrome/browser/translate/translate_infobar_delegate.cc » ('J')