Source/core/inspector/InspectorCSSAgent.cpp - Issue 195953003: Oilpan: Move CSSStyleDeclaration and subclasses to the heap using transistion types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorCSSAgent.cpp

Issue 195953003: Oilpan: Move CSSStyleDeclaration and subclasses to the heap using transistion types. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Review feedback Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InspectorCSSAgent.cpp

diff --git a/Source/core/inspector/InspectorCSSAgent.cpp b/Source/core/inspector/InspectorCSSAgent.cpp

index 69aa4364f9ac238456ecb0d9888b54f6db2bf304..5064f034859ec75c9452b65ce9e340f51a80feee 100644

--- a/Source/core/inspector/InspectorCSSAgent.cpp

+++ b/Source/core/inspector/InspectorCSSAgent.cpp

@@ -745,7 +745,7 @@ void InspectorCSSAgent::getComputedStyleForNode(ErrorString* errorString, int no

if (!node)

return;

- RefPtr<CSSComputedStyleDeclaration> computedStyleInfo = CSSComputedStyleDeclaration::create(node, true);

+ RefPtrWillBeRawPtr<CSSComputedStyleDeclaration> computedStyleInfo = CSSComputedStyleDeclaration::create(node, true);

RefPtr<InspectorStyle> inspectorStyle = InspectorStyle::create(InspectorCSSId(), computedStyleInfo, 0);

style = inspectorStyle->buildArrayForComputedStyle();

}

@@ -775,7 +775,7 @@ void InspectorCSSAgent::getPlatformFontsForNode(ErrorString* errorString, int no

if (!node)

return;

- RefPtr<CSSComputedStyleDeclaration> computedStyleInfo = CSSComputedStyleDeclaration::create(node, true);

+ RefPtrWillBeRawPtr<CSSComputedStyleDeclaration> computedStyleInfo = CSSComputedStyleDeclaration::create(node, true);

*cssFamilyName = computedStyleInfo->getPropertyValue(CSSPropertyFontFamily);

Vector<Node*> textNodes;

« no previous file with comments | « Source/core/frame/DOMWindow.cpp ('k') | Source/core/inspector/InspectorStyleSheet.h » ('j') | no next file with comments »