Fix a bug related with indexed buffer binding.

Fix a bug related with indexed buffer binding.

With bindBufferBase/bindBufferRange, the non-indexed binding should also be set.

BUG=604436
TEST=webgl2_conformance
R=piman@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/4e8906698d053c56d8331eb6715ba27a9b08b5f5
Cr-Commit-Position: refs/heads/master@{#392205}

[Zhenyao Mo, 2016-05-06 20:45:53]

Description was changed from

==========
Fix two bugs related with indexed buffer binding.

1) With bindBufferBase/bindBufferRange, the non-indexed binding is also set.
2) The indexed TRANFORM_FEEDBACK_BUFFER_SIZE/UNIFORM_BUFFER_SIZE should be
   the current bound buffer size if the binding is set through bindBufferBase.

With this CL, the test cases in https://github.com/KhronosGroup/WebGL/pull/1648
all pass.

BUG=604436
TEST=webgl2_conformance
R=piman@chromium.org
==========

to

==========
Fix two bugs related with indexed buffer binding.

1) With bindBufferBase/bindBufferRange, the non-indexed binding is also set.
2) The indexed TRANFORM_FEEDBACK_BUFFER_SIZE/UNIFORM_BUFFER_SIZE should be
   the current bound buffer size if the binding is set through bindBufferBase.

With this CL, the test cases in https://github.com/KhronosGroup/WebGL/pull/1648
all pass.

BUG=604436
TEST=webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-05-06 20:46:30]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-05-06 20:46:46]

piman: PTAL

[commit-bot: I haz the power, 2016-05-06 20:46:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959513003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959513003/1

[Ken Russell (switch to Gerrit), 2016-05-06 20:49:21]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-05-06 20:49:22]

Awesome!

[commit-bot: I haz the power, 2016-05-06 20:49:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 20:49:48]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[piman, 2016-05-06 21:18:48]

lgtm

[Zhenyao Mo, 2016-05-06 21:28:13]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-05-06 21:28:14]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1959513003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-06 21:28:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959513003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959513003/20001

[Zhenyao Mo, 2016-05-06 21:35:02]

The CQ bit was unchecked by zmo@chromium.org

[Zhenyao Mo, 2016-05-06 21:58:21]

Description was changed from

==========
Fix two bugs related with indexed buffer binding.

1) With bindBufferBase/bindBufferRange, the non-indexed binding is also set.
2) The indexed TRANFORM_FEEDBACK_BUFFER_SIZE/UNIFORM_BUFFER_SIZE should be
   the current bound buffer size if the binding is set through bindBufferBase.

With this CL, the test cases in https://github.com/KhronosGroup/WebGL/pull/1648
all pass.

BUG=604436
TEST=webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix a bug related with indexed buffer binding.

With bindBufferBase/bindBufferRange, the non-indexed binding should also be set.

BUG=604436
TEST=webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-05-06 21:59:04]

Description was changed from

==========
Fix a bug related with indexed buffer binding.

With bindBufferBase/bindBufferRange, the non-indexed binding should also be set.

BUG=604436
TEST=webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix a bug related with indexed buffer binding.

With bindBufferBase/bindBufferRange, the non-indexed binding should also be set.

BUG=604436
TEST=webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-05-06 22:02:12]

My apologies, but I got rid of part of patch set 2.

In ES3 spec, it didn't say anything about TRANSFORM_FEEDBACK_BUFFER_SIZE with
BindBufferBase, so I assumed it's the actual buffer size at the time of query.
However, the spec does state clearly for UNIFORM_BUFFER_SIZE, that if it's not
specified during binding (BindBufferBase case), then it should return 0.

I fixed the test in https://github.com/KhronosGroup/WebGL/pull/1649 and updated
this CL accordingly.

[Zhenyao Mo, 2016-05-06 22:02:20]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-06 22:02:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959513003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959513003/40001

[Zhenyao Mo, 2016-05-06 23:29:07]

apparently this also fix conformance2/buffers/buffer-type-restrictions.html

[Zhenyao Mo, 2016-05-06 23:33:09]

Description was changed from

==========
Fix a bug related with indexed buffer binding.

With bindBufferBase/bindBufferRange, the non-indexed binding should also be set.

BUG=604436
TEST=webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix a bug related with indexed buffer binding.

With bindBufferBase/bindBufferRange, the non-indexed binding should also be set.

BUG=604436
TEST=webgl2_conformance
R=piman@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-05-06 23:34:07]

patch set 3 pass CQ dry run.
patch set 4 is simply an update of webgl 2 conformance test expectations.
landing with NOTRY

[Zhenyao Mo, 2016-05-06 23:34:53]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-05-06 23:34:54]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1959513003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-06 23:35:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959513003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959513003/60001

[commit-bot: I haz the power, 2016-05-06 23:40:54]

Description was changed from

==========
Fix a bug related with indexed buffer binding.

With bindBufferBase/bindBufferRange, the non-indexed binding should also be set.

BUG=604436
TEST=webgl2_conformance
R=piman@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix a bug related with indexed buffer binding.

With bindBufferBase/bindBufferRange, the non-indexed binding should also be set.

BUG=604436
TEST=webgl2_conformance
R=piman@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-05-06 23:40:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-06 23:42:53]

Description was changed from

==========
Fix a bug related with indexed buffer binding.

With bindBufferBase/bindBufferRange, the non-indexed binding should also be set.

BUG=604436
TEST=webgl2_conformance
R=piman@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix a bug related with indexed buffer binding.

With bindBufferBase/bindBufferRange, the non-indexed binding should also be set.

BUG=604436
TEST=webgl2_conformance
R=piman@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/4e8906698d053c56d8331eb6715ba27a9b08b5f5
Cr-Commit-Position: refs/heads/master@{#392205}
==========

[commit-bot: I haz the power, 2016-05-06 23:42:54]

Patchset 4 (id:??) landed as
https://crrev.com/4e8906698d053c56d8331eb6715ba27a9b08b5f5
Cr-Commit-Position: refs/heads/master@{#392205}