Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1959513002: Revert of Fix invalid using decl in bionic relocation_packer (Closed)

Created:
4 years, 7 months ago by Reid Kleckner
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix invalid using decl in bionic relocation_packer (patchset #1 id:1 of https://codereview.chromium.org/1953863002/ ) Reason for revert: Broke Android builds due to missing namespace qualifier Original issue's description: > Fix invalid using decl in bionic relocation_packer > > The code was essentially doing 'using Logger::INFO' in the global > namespace to make its 'LOG(INFO)' macros work. Unfortunately, C++ does > not allow you to use using decls on classes like this unless you are in > a derived class. GCC does not accept this code, and Clang was recently > updated (LLVM r268594) to reject it as well. > > This should fix the Chromium Android ASan build with TOT Clang: > https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/ > > I'll send this patch along to AOSP after fixing it here. > > R=thakis@chromium.org,sgurun@chromium.org > BUG=609543 > > Committed: https://crrev.com/4fbaaecb9433f9503946be68d0ecef63a1b4a164 > Cr-Commit-Position: refs/heads/master@{#391920} TBR=sgurun@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609543 Committed: https://crrev.com/0e51f7ced0481ce1d31933c64519d0842a52b5c9 Cr-Commit-Position: refs/heads/master@{#391923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M third_party/android_platform/README.chromium View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/android_platform/bionic/tools/relocation_packer/src/debug.h View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Reid Kleckner
Created Revert of Fix invalid using decl in bionic relocation_packer
4 years, 7 months ago (2016-05-05 22:17:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959513002/1
4 years, 7 months ago (2016-05-05 22:18:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 22:19:10 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 22:20:38 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e51f7ced0481ce1d31933c64519d0842a52b5c9
Cr-Commit-Position: refs/heads/master@{#391923}

Powered by Google App Engine
This is Rietveld 408576698