Chromium Code Reviews
DescriptionRevert of Fix invalid using decl in bionic relocation_packer (patchset #1 id:1 of https://codereview.chromium.org/1953863002/ )
Reason for revert:
Broke Android builds due to missing namespace qualifier
Original issue's description:
> Fix invalid using decl in bionic relocation_packer
>
> The code was essentially doing 'using Logger::INFO' in the global
> namespace to make its 'LOG(INFO)' macros work. Unfortunately, C++ does
> not allow you to use using decls on classes like this unless you are in
> a derived class. GCC does not accept this code, and Clang was recently
> updated (LLVM r268594) to reject it as well.
>
> This should fix the Chromium Android ASan build with TOT Clang:
> https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/
>
> I'll send this patch along to AOSP after fixing it here.
>
> R=thakis@chromium.org,sgurun@chromium.org
> BUG=609543
>
> Committed: https://crrev.com/4fbaaecb9433f9503946be68d0ecef63a1b4a164
> Cr-Commit-Position: refs/heads/master@{#391920}
TBR=sgurun@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=609543
Committed: https://crrev.com/0e51f7ced0481ce1d31933c64519d0842a52b5c9
Cr-Commit-Position: refs/heads/master@{#391923}
Patch Set 1 #
Messages
Total messages: 5 (1 generated)
|
||||||||||||||||||||||||||||