Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 19595004: Rename AllocationSiteInfo to AllocationMemento (Closed)

Created:
7 years, 5 months ago by mvstanton
Modified:
7 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Rename AllocationSiteInfo to AllocationMemento This is just a rename change with the exception of a bug found along the way in CodeStubGraphBuilder<FastCloneShallowArrayStub>::BuildCodeStub(). There, the intent is to get the boilerplate object from an AllocationSite. But the wrong HObjectAccess was used. It only succeeds because it happened to be the same offset :). BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -163 lines) Patch
M src/arm/codegen-arm.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M src/builtins.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap.cc View 5 chunks +17 lines, -17 lines 0 comments Download
M src/hydrogen.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 8 chunks +22 lines, -22 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M src/mips/codegen-mips.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M src/objects.h View 5 chunks +10 lines, -10 lines 0 comments Download
M src/objects.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-printer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/codegen-x64.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Benedikt, Would you have a look at this rename change? It's been on the ...
7 years, 5 months ago (2013-07-19 13:09:31 UTC) #1
Benedikt Meurer
LGTM :-)
7 years, 5 months ago (2013-07-19 13:29:24 UTC) #2
mvstanton
7 years, 5 months ago (2013-07-19 13:31:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15778 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698