Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 1959473002: [Mac][Material Design] Fix ManagePasswordsDecoration unit tests (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Fix ManagePasswordsDecoration unit tests Under Material Design the ManagePasswordsDecoration unit tests broke because of comparing the old PNG icons to the new vector icons, and because of a NULL pointer dereference. R=avi@chromium.org BUG=609578 Committed: https://crrev.com/8ef553f7f2825bdeb386996fa105193255b64271 Cr-Commit-Position: refs/heads/master@{#391930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm View 2 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 7 months ago (2016-05-05 21:01:03 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-05 21:06:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959473002/1
4 years, 7 months ago (2016-05-05 21:17:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 22:39:33 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 22:40:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ef553f7f2825bdeb386996fa105193255b64271
Cr-Commit-Position: refs/heads/master@{#391930}

Powered by Google App Engine
This is Rietveld 408576698