Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1959463003: MIPS64: Fix 'Visit the Optimized Code Map on first call rather than closure creation.' (Closed)

Created:
4 years, 7 months ago by akos.palfi.imgtec
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix 'Visit the Optimized Code Map on first call rather than closure creation.' Port c2de9611281d6da70fe1770072ec55f2f8aaf467 Fixes an infinite loop on MIPS64 big-endian. BUG= Committed: https://crrev.com/643dfe0d056fe2be17c6771ac8d23644a1df5a42 Cr-Commit-Position: refs/heads/master@{#36090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/mips64/builtins-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
akos.palfi.imgtec
PTAL.
4 years, 7 months ago (2016-05-06 19:09:24 UTC) #2
balazs.kilvady
lgtm
4 years, 7 months ago (2016-05-06 19:13:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959463003/1
4 years, 7 months ago (2016-05-06 19:22:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 19:49:37 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/643dfe0d056fe2be17c6771ac8d23644a1df5a42 Cr-Commit-Position: refs/heads/master@{#36090}
4 years, 7 months ago (2016-05-06 19:50:23 UTC) #8
mvstanton
4 years, 7 months ago (2016-05-09 09:19:46 UTC) #9
Message was sent while issue was closed.
Thanks for this!

Powered by Google App Engine
This is Rietveld 408576698