Allow building with VS 2015 Update 3 pre-release

Allow building with VS 2015 Update 3 pre-release

Add toolchain hash for Update 3 pre-release and fix declarations of
delay-load hooks for VS 2015 Update 3. The new toolchain is not used
unless you go "set DEPOT_TOOLS_WIN_TOOLCHAIN_PRERELEASE=1", run
"gclient runhooks", and then regenerate ninja files (if using gn).
Therefore this change is a NOP for the build machines and the code
we ship.

VS 2015 Update 3 changes the delay hook function pointers to be const
because this is important for security. This matches that change.

The new compiler is discussed here:
https://blogs.msdn.microsoft.com/vcblog/2016/05/04/new-code-optimizer/

The version packaged up for this change was installed May 16th.

BUG=440500
Committed: https://crrev.com/a80d80c3e4c086a791b93a07ee089413fa60630d
Cr-Commit-Position: refs/heads/master@{#394031}

[brucedawson, 2016-05-10 18:54:07]

Description was changed from

==========
Add toolchain hash for Update 3 pre-release

Do not commit!!!

BUG=440500
==========

to

==========
Build with VS 2015 Update 3 pre-release

Add toolchain hash for Update 3 pre-release and fix declarations of
delay-load hooks for VS 2015 Update 3

VS 2015 Update 3 changes the delay hook function pointers to be const
because this is important for security. This matches that change.

Do not commit until this corresponds to Update 3 final.

BUG=440500
==========

[brucedawson, 2016-05-12 17:10:54]

Description was changed from

==========
Build with VS 2015 Update 3 pre-release

Add toolchain hash for Update 3 pre-release and fix declarations of
delay-load hooks for VS 2015 Update 3

VS 2015 Update 3 changes the delay hook function pointers to be const
because this is important for security. This matches that change.

Do not commit until this corresponds to Update 3 final.

BUG=440500
==========

to

==========
Build with VS 2015 Update 3 pre-release

Add toolchain hash for Update 3 pre-release and fix declarations of
delay-load hooks for VS 2015 Update 3

VS 2015 Update 3 changes the delay hook function pointers to be const
because this is important for security. This matches that change.

The new compiler is discussed here:
https://blogs.msdn.microsoft.com/vcblog/2016/05/04/new-code-optimizer/

The version packaged up for this change was installed May 9th.

Do not commit until this corresponds to Update 3 final.

BUG=440500
==========

[scottmg, 2016-05-12 18:34:38]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2016-05-12 18:34:38]

It'd be great if you could land this now (does the code need an #if _MSC_VER?)
as it's a bit fiddly to maintain local modifications while working on other
things.

https://codereview.chromium.org/1959413002/diff/40001/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/1959413002/diff/40001/build/vs_toolchain.py#n...
build/vs_toolchain.py:283: return ['97b5c1d5f7c614126da344d55a20dcc424f578eb']
with a

if bool(int(os.environ.get('DEPOT_TOOLS_WIN_TOOLCHAIN_PRERELEASE', '0'))) == 1:

here.

[scottmg, 2016-05-12 18:35:18]

On 2016/05/12 18:34:38, scottmg wrote:
> It'd be great if you could land this now (does the code need an #if _MSC_VER?)
> as it's a bit fiddly to maintain local modifications while working on other
> things.
> 
> https://codereview.chromium.org/1959413002/diff/40001/build/vs_toolchain.py
> File build/vs_toolchain.py (right):
> 
>
https://codereview.chromium.org/1959413002/diff/40001/build/vs_toolchain.py#n...
> build/vs_toolchain.py:283: return ['97b5c1d5f7c614126da344d55a20dcc424f578eb']
> with a
> 
> if bool(int(os.environ.get('DEPOT_TOOLS_WIN_TOOLCHAIN_PRERELEASE', '0'))) ==
1:
> 
> here.

(assuming final U3 isn't going to be very soon; in that case, don't bother)

[brucedawson, 2016-05-12 20:29:40]

The code would need an #if _MSC_FULL_VER (_MSC_VER only changes on major
releases) which would then cause win_clang to break when the environment
variable was set, but that's easily avoidable.

I do like the idea of letting developers try this by setting an environment
variable instead of by patching in a CL. Once the pre-release binaries are in
goma I'll see about doing that.

[brucedawson, 2016-05-16 23:22:34]

This is now updated to a form that allows it to be committed - the toolchain is
selected using an environment variable, and an appropriate #if was added.

Also, the toolchain was updated to the May 16th version because the May 9th
version was missing x86_amd64\cl.exe, which is needed for goma.

Ironically this CL cannot be used for testing Update 3 on the try bots as that
requires an unconditional switch to Update 3, but a separate CL (not committed)
can be used for that purpose.

PTAL.

[brucedawson, 2016-05-16 23:24:23]

Description was changed from

==========
Build with VS 2015 Update 3 pre-release

Add toolchain hash for Update 3 pre-release and fix declarations of
delay-load hooks for VS 2015 Update 3

VS 2015 Update 3 changes the delay hook function pointers to be const
because this is important for security. This matches that change.

The new compiler is discussed here:
https://blogs.msdn.microsoft.com/vcblog/2016/05/04/new-code-optimizer/

The version packaged up for this change was installed May 9th.

Do not commit until this corresponds to Update 3 final.

BUG=440500
==========

to

==========
Allow building with VS 2015 Update 3 pre-release

Add toolchain hash for Update 3 pre-release and fix declarations of
delay-load hooks for VS 2015 Update 3. The new toolchain is not used
unless you go "set DEPOT_TOOLS_WIN_TOOLCHAIN_PRERELEASE=1", run
"gclient runhooks", and then regenerate ninja files (if using gn).
Therefore this change is a NOP for the build machines and the code
we ship.

VS 2015 Update 3 changes the delay hook function pointers to be const
because this is important for security. This matches that change.

The new compiler is discussed here:
https://blogs.msdn.microsoft.com/vcblog/2016/05/04/new-code-optimizer/

The version packaged up for this change was installed May 16th.

BUG=440500
==========

[scottmg, 2016-05-16 23:35:23]

lgtm

[scottmg, 2016-05-16 23:35:53]

And set DEPOT_TOOLS_WIN_TOOLCHAIN_PRERELEASE=1!

[brucedawson, 2016-05-16 23:44:26]

brucedawson@chromium.org changed reviewers:
+ grt@chromium.org

[brucedawson, 2016-05-16 23:44:27]

grt@ can you look at the delay_load_hook_win.cc change?

[grt (UTC plus 2), 2016-05-17 00:59:42]

rubberstamp lgtm

[brucedawson, 2016-05-17 02:37:54]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-05-17 02:38:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959413002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959413002/60001

[commit-bot: I haz the power, 2016-05-17 02:44:13]

Description was changed from

==========
Allow building with VS 2015 Update 3 pre-release

Add toolchain hash for Update 3 pre-release and fix declarations of
delay-load hooks for VS 2015 Update 3. The new toolchain is not used
unless you go "set DEPOT_TOOLS_WIN_TOOLCHAIN_PRERELEASE=1", run
"gclient runhooks", and then regenerate ninja files (if using gn).
Therefore this change is a NOP for the build machines and the code
we ship.

VS 2015 Update 3 changes the delay hook function pointers to be const
because this is important for security. This matches that change.

The new compiler is discussed here:
https://blogs.msdn.microsoft.com/vcblog/2016/05/04/new-code-optimizer/

The version packaged up for this change was installed May 16th.

BUG=440500
==========

to

==========
Allow building with VS 2015 Update 3 pre-release

Add toolchain hash for Update 3 pre-release and fix declarations of
delay-load hooks for VS 2015 Update 3. The new toolchain is not used
unless you go "set DEPOT_TOOLS_WIN_TOOLCHAIN_PRERELEASE=1", run
"gclient runhooks", and then regenerate ninja files (if using gn).
Therefore this change is a NOP for the build machines and the code
we ship.

VS 2015 Update 3 changes the delay hook function pointers to be const
because this is important for security. This matches that change.

The new compiler is discussed here:
https://blogs.msdn.microsoft.com/vcblog/2016/05/04/new-code-optimizer/

The version packaged up for this change was installed May 16th.

BUG=440500
==========

[commit-bot: I haz the power, 2016-05-17 02:44:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-17 02:45:41]

Description was changed from

==========
Allow building with VS 2015 Update 3 pre-release

Add toolchain hash for Update 3 pre-release and fix declarations of
delay-load hooks for VS 2015 Update 3. The new toolchain is not used
unless you go "set DEPOT_TOOLS_WIN_TOOLCHAIN_PRERELEASE=1", run
"gclient runhooks", and then regenerate ninja files (if using gn).
Therefore this change is a NOP for the build machines and the code
we ship.

VS 2015 Update 3 changes the delay hook function pointers to be const
because this is important for security. This matches that change.

The new compiler is discussed here:
https://blogs.msdn.microsoft.com/vcblog/2016/05/04/new-code-optimizer/

The version packaged up for this change was installed May 16th.

BUG=440500
==========

to

==========
Allow building with VS 2015 Update 3 pre-release

Add toolchain hash for Update 3 pre-release and fix declarations of
delay-load hooks for VS 2015 Update 3. The new toolchain is not used
unless you go "set DEPOT_TOOLS_WIN_TOOLCHAIN_PRERELEASE=1", run
"gclient runhooks", and then regenerate ninja files (if using gn).
Therefore this change is a NOP for the build machines and the code
we ship.

VS 2015 Update 3 changes the delay hook function pointers to be const
because this is important for security. This matches that change.

The new compiler is discussed here:
https://blogs.msdn.microsoft.com/vcblog/2016/05/04/new-code-optimizer/

The version packaged up for this change was installed May 16th.

BUG=440500

Committed: https://crrev.com/a80d80c3e4c086a791b93a07ee089413fa60630d
Cr-Commit-Position: refs/heads/master@{#394031}
==========

[commit-bot: I haz the power, 2016-05-17 02:45:42]

Patchset 4 (id:??) landed as
https://crrev.com/a80d80c3e4c086a791b93a07ee089413fa60630d
Cr-Commit-Position: refs/heads/master@{#394031}