Issue 19594005: Use a mock implementation of Platform::crypto() for layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19594005: Use a mock implementation of Platform::crypto() for layout tests. (Closed)

Created:
7 years, 5 months ago by eroman

Modified:
7 years, 5 months ago

Reviewers:
darin (slow to review), jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
M	content/public/renderer/content_renderer_client.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	content/public/renderer/content_renderer_client.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/shell/renderer/shell_content_renderer_client.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/shell/renderer/shell_content_renderer_client.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/19594005/2001

7 years, 5 months ago (2013-07-25 16:31:38 UTC) #3

eroman

@darin could you review the two content/public/renderer/* files? (Looks like Joi is on vacation). Thanks!

7 years, 5 months ago (2013-07-25 16:59:26 UTC) #4

eroman

7 years, 5 months ago (2013-07-25 20:06:25 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r213680 (presubmit successful).