Handlify JSFunction::SetPrototype method.

Handlify JSFunction::SetPrototype method.

R=verwaest@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=15738

[Toon Verwaest, 2013-07-17 16:25:20]

lgtm with nits

https://codereview.chromium.org/19594002/diff/1/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/19594002/diff/1/src/accessors.cc#newcode451
src/accessors.cc:451: MaybeObject* Accessors::FunctionGetPrototype(Object*
object, void*) {
This function doesn't return failure anymore, so change the return-type to
Object*.

https://codereview.chromium.org/19594002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/19594002/diff/1/src/objects.cc#newcode9555
src/objects.cc:9555: Handle<Map> new_map =
Map::Copy(Handle<Map>(function->initial_map()));
Lets use handle(function->initial_map) since it's shorter. Also below for
Handle<Context>.

[Michael Starzinger, 2013-07-17 17:12:53]

Addressed comments. Landing.

https://codereview.chromium.org/19594002/diff/1/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/19594002/diff/1/src/accessors.cc#newcode451
src/accessors.cc:451: MaybeObject* Accessors::FunctionGetPrototype(Object*
object, void*) {
On 2013/07/17 16:25:20, Toon Verwaest wrote:
> This function doesn't return failure anymore, so change the return-type to
> Object*.

As discussed offline: We cannot change the return value as a function point to
this function is used. But I made the declaration private to make sure it isn't
called from anywhere.

https://codereview.chromium.org/19594002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/19594002/diff/1/src/objects.cc#newcode9555
src/objects.cc:9555: Handle<Map> new_map =
Map::Copy(Handle<Map>(function->initial_map()));
On 2013/07/17 16:25:20, Toon Verwaest wrote:
> Lets use handle(function->initial_map) since it's shorter. Also below for
> Handle<Context>.

Done.

[Michael Starzinger, 2013-07-18 07:59:57]

Committed patchset #2 manually as r15738 (presubmit successful).