Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1959373002: Rework plugin API to work better with strong mode (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/plugin.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -44 lines) Patch
M lib/plugin.dart View 3 chunks +15 lines, -8 lines 0 comments Download
M lib/src/plugin_impl.dart View 5 chunks +10 lines, -17 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/plugin_impl_test.dart View 5 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 7 months ago (2016-05-10 15:40:35 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-10 15:51:59 UTC) #3
Brian Wilkerson
4 years, 7 months ago (2016-05-10 16:07:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f7910ce8fa5c0fede2ab2ff44935dccdbb85de6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698